637207 - "name" and "message" enumerable on *Error.prototype

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mark S. Miller]

For all so-called NativeError.prototype objects, their "name" and "message" properties are enumerable when they shouldn't be.

I am classifying this as minor since an initialization script can easily repair this using Object.defineProperty.

Comment 1

[Andreas Gal :gal]

js> for (i in Error.prototype) print(i)
name
message
fileName
lineNumber

Comment 2

[Andreas Gal :gal]

exn_enumerate() looks really weird and unnecessary. Sounds like we can easily fix this for FF5.

Comment 3

[Brendan Eich [:brendan]]

Missed when fixing bug 574867.

/be

Comment 4

[Mark S. Miller]

http://code.google.com/p/v8/issues/detail?id=1215

Comment 5

[Mark S. Miller]

https://bugs.webkit.org/show_bug.cgi?id=55347

Comment 6

[Cameron McCormack (:heycam)]

I'll try this.

Comment 7

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 8

[Nickolay_Ponomarev]

Looks like it landed: http://hg.mozilla.org/mozilla-central/rev/9743d95d473e

Comment 9

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: followup to remove declaration of removed function

The removed function ("exn_enumerate") is still declared at the top of jsexn.cpp (but never defined or used), which triggers:
../../../mozilla/js/src/jsexn.cpp:83: warning: ‘JSBool exn_enumerate(JSContext*, JSObject*)’ declared ‘static’ but never defined

The attached trivial followup should fix this.

Comment 10

[Andreas Gal :gal]

Comment on attachment 526415 [details] [diff] [review]
followup to remove declaration of removed function

Thanks.

Comment 11

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Landed followup: http://hg.mozilla.org/mozilla-central/rev/19f14915646a