637224 - Findbar leaves blank space when navigating back while in use

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Ian Nartowicz]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

The findbar disappears when back (button or keystroke) is pressed, but a blank white space is left and the content area remains the same size it was when the findbar was open.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.mesagarden.com/
2. Click the first link, "Acanthocalycium to Epithelantha"
3. Typeahead find text "davisii"
4. Press backspace/alt-back-arrow, or back button before the findbar closes itself
Actual Results:  
The previous page appears instantly, but the content is smaller than the window and a blank space remains where the findbar was.

Expected Results:  
The previous page appears filling the available content space.  I guess the findbar is supposed to disappear now on navigation

Although this might appear to be connected to the recent "close findbar on navigation" fix, it happens for me at least as far back as beta 9.

Some people have repoted not seeing this, but others have including on Windows 7.  It happens for me in safe mode.  It doesn't happen on all pages, but it does happen on more than just the one in the example.  I think anything that isn't completely cached triggers the white space to disappear.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Confirming and setting to new.  I see this on Win7 x64 given the STR by the OP.

Tested using latest hourly build on 4.0b13pre 
cset: http://hg.mozilla.org/mozilla-central/rev/35b6854b0159

Its also been noted that this may have been going on since b9...

Comment 2

[Alice0775 White]

Regresson window:
Works:
http://hg.mozilla.org/mozilla-central/rev/e7e7a4fe417c
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100421 Minefield/3.7a5pre ID:20100421065127
Fails:
http://hg.mozilla.org/mozilla-central/rev/8c551a93eedd
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100421 Minefield/3.7a5pre ID:20100421084103
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7e7a4fe417c&tochange=8c551a93eedd

Comment 3

[Alice0775 White]

In local build,
build from f3abfe490d7f :fails
build from e7e7a4fe417c :works
Regressed by:
f3abfe490d7f	Neil Deakin — Bug 418521, improve the way focus indicators are displayed to correlate better with system behaviour, add -moz-focusring property to apply only when focus rings should be drawn, r=dao,jmathies,dbaron sr=neil

Comment 4

[Alice0775 White]

This problem also happens on http://www.mozilla.com/en-US/mobile/
So, this problem is not a special. and should be fixed.

Steps to Reproduce:
1. Go to http://www.mozilla.com/en-US/mobile/
2.Learn More »  in the paragraph "Your Life In Sync"
3. Typeahead find (/)
4. Press backspace/alt-back-arrow, or back button before the findbar closes

Comment 5

[Alice0775 White]

Google.com also.
http://www.google.com/search?hl=en&source=hp&q=firefox&aq=f&aqi=g10&aql=&oq=
and first search result link

Comment 6

[Alice0775 White]

After landing Bug 628179. This problem can happen _frequently_.

Steps to Reproduce:
1. Go to http://www.google.com/
2. Search Firefox
3. Click  first search result link
4. Open Findbar Ctrl+F
5. Navigation Back (the Findbar will hide automatically)

Comment 7

[Timothy Nikkel (:tnikkel)]

I wonder if we get an assertions when this happens in a debug build.

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

I am unable to repo this on 3.6.13 on WinXP SP3.  

So, is this Win7/Vista only or something with Hardware Accel ?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Jim, this bug is 4.0-specific.  It's not present in 3.6.x.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking until we back out bug 628179 which made this more apparent. Once that's backed out, we'll unblock on this.

Comment 11

[(no longer active)]

Unblocking now that bug 628179 is backed out.

Comment 12

[Ian Nartowicz]

In latest nightly, a findbar invoked with ctrl-F remains even after navigation.  So no blank space appears when navigating back in any case I've tested.

A findbar invoked with typeahead find still disappears on navigation (it always did, right, not just on timeout?) so the blank space can still appear in those cases.  I never noticed this prior to the recent changes although going back now it is easy to reproduce.

Comment 13

[Jens Stutte [:jstutte]]

This seems to work in today's nightly, and I assume it is not worth understanding what fixed it.