637238 - Crash comment allows formatted text

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gordon P. Hemsley [:GPHemsley]]

I was under the impression that crash comments were just plain text. But I accidentally pasted formatted text into the box, and it changed in font weight and size, and did not revert when I typed further. The crash-stats server appears to have stripped the formatting, though.

To reproduce, just copy and paste some formatted text, e.g. from the browser. (In this instance, I was pasting some text from a Gmail e-mail header.)

Comment 1

[(not currently active) Ted Mielczarek]

The edit box is a subclass of NSTextView, and I just realized that in Interface Builder there's a checkbox on its attributes pane: "Allows: [x] Rich Text". This is probably as simple as just unchecking that box.

Comment 2

[Mukul Chaware]

Hi, I would like to work on this bug.I am newbie and this is my first bug.Can you tell please me how should I proceed? 
Thanks

Comment 3

[Mike Hoye [:mhoye]]

Hi, Mukul - 

First thing you'll need to do is to get your development environment set up so that you can build your own version of Firefox. These two pages:

https://developer.mozilla.org/en-US/docs/Introduction

https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

... should help you get started. 

After that, you'll need to figure out where to make the change and push up a patch. As soon as you have a first try at a patch attached to the bug, we'll assign the bug to you.

Comment 4

[Mukul Chaware]

Thanks for the reply.
I have built firefox nightly succesfully but I don't know how to proceed after this.Do i have to change this toolkit/crashreporter/client/crashreporter_osx.h?

Comment 5

[Mike Hoye [:mhoye]]

Looks like it - Ted, can you confirm?

Comment 6

[(not currently active) Ted Mielczarek]

I believe what you actually want to do is open the MainMenu.nib file under toolkit/crashreporter/client/macbuild/Contents/Resources/English.lproj in Interface Builder, and edit it as I mentioned in comment 1.

The files are here:
http://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/client/macbuild/Contents/Resources/English.lproj

Comment 7

[Mukul Chaware]

sorry for late reply..I can't solve this bug as I don't have mac OS..sorry

Comment 8

[Jeffrey Tran]

Attachment: rev1 - Removes formatting from crash comments

Patch is generated by unchecking the Rich Text option in MainMenu.nib

Comment 9

[Jeffrey Tran]

Doesn't look like anyone is working on this bug so I went ahead and uploaded a patch. Thanks

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 8708757 [details] [diff] [review]
rev1 - Removes formatting from crash comments

Review of attachment 8708757 [details] [diff] [review]:
-----------------------------------------------------------------

I am tentatively r+ing this, but this needs a run past the try server to make sure it builds and the resulting binary comes out OK! Do you have access to the Try server or do you need someone to push it for you?

Comment 11

[Jeffrey Tran]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #10)
> Comment on attachment 8708757 [details] [diff] [review]
> rev1 - Removes formatting from crash comments
> 
> Review of attachment 8708757 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I am tentatively r+ing this, but this needs a run past the try server to
> make sure it builds and the resulting binary comes out OK! Do you have
> access to the Try server or do you need someone to push it for you?

I will push it to the try server myself. Thanks

Comment 12

[Jeffrey Tran]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30c03b2288b1

Comment 13

[Jeffrey Tran]

Do the results from the try push look ok?

Comment 14

[(not currently active) Ted Mielczarek]

Sorry, that took me a long time to get to. Yes, that looks good, thanks!

Comment 15

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27070ffbbac79e66353ec035cafe85bea1343200
Bug 637238 - Uncheck rich text option in MainMenu.nib. r=ted

Comment 16

[(not currently active) Ted Mielczarek]

Thanks for the patch!

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27070ffbbac7