637246 - generator.close() should return undefined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dave Herman [:dherman]]

Apparently generator.close() got turned into a fast native but doesn't explicitly return the undefined value, so it accidentally returns the callee from the operand stack:

    js> (function(){yield})().close()
    function close() {[native code]}

Dave

Comment 1

[Luke Wagner [:luke]]

Attachment: fix

Arg, incomplete human-powered control flow analysis.

Thanks for finding Dave!

Comment 2

[Luke Wagner [:luke]]

Trivial patch fixing minor bug; hard to judge whether I should request approval for 2.0.  I'm going to default to 'no' given the late stage.

Comment 3

[Brendan Eich [:brendan]]

Not a regression, ancient bug -- can't block but couldn't hurt. Land when Fx4 has "branched" is the right answer.

/be

Comment 4

[Luke Wagner [:luke]]

http://hg.mozilla.org/tracemonkey/rev/f5fbe627578d

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/f5fbe627578d