Closed
Bug 637401
Opened 13 years ago
Closed 13 years ago
[regression] Console message nodes do not have unique IDs anymore
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0
People
(Reporter: ddahl, Assigned: ddahl)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
4.76 KB,
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
The original landing of the console included a unique ID for each message node logged to the console. Somewhere along the way we lost these ids an each message node is now ID-less The devtools SDK will include hooks to get and change nodes in almost any way. that will be much more difficult without IDs.
Assignee | ||
Updated•13 years ago
|
Keywords: regression
Comment 1•13 years ago
|
||
I expect this happened around the console restyling patches as they were a near re-write of the message nodes.
Assignee | ||
Comment 2•13 years ago
|
||
Fixes the node ID issue - this is a dependency of bug 636169
Assignee: nobody → ddahl
Attachment #515704 -
Flags: review?(dtownsend)
Assignee | ||
Updated•13 years ago
|
Attachment #515704 -
Flags: approval2.0?
Assignee | ||
Comment 3•13 years ago
|
||
sorry about the fuck up:(
Attachment #515704 -
Attachment is obsolete: true
Attachment #515704 -
Flags: review?(dtownsend)
Attachment #515704 -
Flags: approval2.0?
Attachment #515705 -
Flags: review?(dtownsend)
Updated•13 years ago
|
Attachment #515705 -
Flags: review?(dtownsend)
Attachment #515705 -
Flags: review+
Attachment #515705 -
Flags: approval2.0+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e70c07f8d9db
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → Firefox 4.0
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•