Closed Bug 637446 Opened 9 years ago Closed 9 years ago

Run jit-tests even if ENABLE_TRACEJIT isn't defined.

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: paul.biggar, Assigned: paul.biggar)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file)

The jit-tests are predicated on ENABLE_TRACEJIT, though they work on all configurations I've tried. We should run them in all configs.
Attachment #515727 - Flags: review?(nnethercote)
Comment on attachment 515727 [details] [diff] [review]
Test on all configs, not just ENABLE_TRACEJIT.

Fine by me so long as it doesn't cause failures.  Though it looks like that patch is on top of some other changes in your tree?  Eg. you have JITFLAGS defined, which isn't in TM, but is in the patch I have in bug 635155, but I don't have the ',' at the start.
Attachment #515727 - Flags: review?(nnethercote) → review+
Yup, it's on top of bug 637390 (which itself is based on bug 635155).
Oh, I should read all my bugmail before commenting... I see now this is on top of bug 637390.
https://hg.mozilla.org/tracemonkey/rev/918ded339aa4
Whiteboard: [fixed-in-tracemonkey]
http://hg.mozilla.org/mozilla-central/rev/918ded339aa4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.