MozMillAsyncTest is present but unused

RESOLVED FIXED

Status

Testing Graveyard
Mozmill
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: Jeff Hammel, Assigned: Jeff Hammel)

Tracking

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
We have a class for at least a type of Mozmill test:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/controller.js#L1296

As best as I can tell, this isn't used anywhere either in the harness
code or in QA's mozmill-tests, outside of a few cursory checks for it
in frame.js.

Is anyone using this code?  Does it have any sort of intent worth
keeping?  Or is it just sitting there being confusing?  If no one is
using it, I would very much want to take it out
(Assignee)

Updated

7 years ago
Whiteboard: [mozmill-2.0?]
(Assignee)

Comment 1

7 years ago
see example removal in https://github.com/k0s/mozmill/commit/e1771c9e22c9836819c0a873277284888244ed67 ; abict, tests are unaffected by the removal
Jeff, please send a message to the mozmill-dev list to ensure other projects aren't using this class. If it is the case we have to offer an alternative if you want to remove it.
(Assignee)

Comment 3

7 years ago
See http://groups.google.com/group/mozmill-dev/browse_frm/thread/63dfd454f5213287

Additional discussion welcome

Comment 4

7 years ago
+'sing cause we need to figure out whether to remove this or fold it into stuff going forward.  I think this was a bright idea that never went anywhere, but we may need to come back to it for e10s support.
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
(Assignee)

Comment 5

7 years ago
So this is to be removed, as agreed on.
Assignee: nobody → jhammel
Blocks: 641615
(Assignee)

Comment 6

7 years ago
Created attachment 519555 [details] [diff] [review]
eliminate MozMillAsyncTest
Attachment #519555 - Flags: review?(fayearthur+bugs)
Comment on attachment 519555 [details] [diff] [review]
eliminate MozMillAsyncTest

I like it.
Attachment #519555 - Flags: review?(fayearthur+bugs) → review+
(Assignee)

Comment 8

7 years ago
pushed to master: https://github.com/mozautomation/mozmill/commit/de29ddf29a7ba981e745dcff439cbf8a39ac51a1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.