637471 - MozMillAsyncTest is present but unused

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

We have a class for at least a type of Mozmill test:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/controller.js#L1296

As best as I can tell, this isn't used anywhere either in the harness
code or in QA's mozmill-tests, outside of a few cursory checks for it
in frame.js.

Is anyone using this code?  Does it have any sort of intent worth
keeping?  Or is it just sitting there being confusing?  If no one is
using it, I would very much want to take it out

Comment 1

[Jeff Hammel]

see example removal in https://github.com/k0s/mozmill/commit/e1771c9e22c9836819c0a873277284888244ed67 ; abict, tests are unaffected by the removal

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Jeff, please send a message to the mozmill-dev list to ensure other projects aren't using this class. If it is the case we have to offer an alternative if you want to remove it.

Comment 3

[Jeff Hammel]

See http://groups.google.com/group/mozmill-dev/browse_frm/thread/63dfd454f5213287

Additional discussion welcome

Comment 4

[cmtalbert]

+'sing cause we need to figure out whether to remove this or fold it into stuff going forward.  I think this was a bright idea that never went anywhere, but we may need to come back to it for e10s support.

Comment 5

[Jeff Hammel]

So this is to be removed, as agreed on.

Comment 6

[Jeff Hammel]

Attachment: eliminate MozMillAsyncTest

Comment 7

[Heather Arthur [:harth]]

Comment on attachment 519555 [details] [diff] [review]
eliminate MozMillAsyncTest

I like it.

Comment 8

[Jeff Hammel]

pushed to master: https://github.com/mozautomation/mozmill/commit/de29ddf29a7ba981e745dcff439cbf8a39ac51a1