637508 - graph_server_post.py and hgtool.py assume simplejson

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Both of these scripts have failed in my testing of bug 631851, because simplejson is not included in the virtualenv.

We're running Python-2.6.5, so as far as I know there's no reason not to try using the built-in json and fall back to simplejson if that's not found.

At any rate, I'll add simplejson to the virtualenv -- but it would be good to be able to remove this dependency.

Comment 1

[Mike Taylor [:bear]]

this is the import "trick" I use to cover this case:

try:
  import json
except ImportError:
  import simplejson as json

Comment 2

[Chris AtLee [:catlee]]

(In reply to comment #1)
> this is the import "trick" I use to cover this case:
> 
> try:
>   import json
> except ImportError:
>   import simplejson as json

I'd rather do it the other way round and import simplejson, falling back to json if it's not available. python 2.6's json is a few orders of magnitude slower than simplejson.

Comment 3

[Aki Sasaki (not active)]

This appears fixed, though the opposite order from comment 2.