637897 - Make Loaded Scripts Search case-insensitive

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

Something that has always been bugging me: The scripts search is case-sensitive. This is not user-friendly at all, and since I don't see any major use case for the current behavior I suggest we don't even provide an option (like a hidden pref) for getting the old behavior back.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: extended patch [Checkin: comment 3]

While I was waiting for a review I thought I'd just as well fix this for real, i.e. make the filter apply in all cases and not just for the files that are currently listed. What happens without the patch I'm attaching is that files are just added to the scripts view without taking the current filter into account. To apply the filter to the new files you have to modify the filter, which is bad design. Instead the filter should apply at all times, which is what my new patch does.

Note: The scriptsView tests are needed because scriptsView.currentContent is not yet defined in the startup case so getChildById would throw without that check. Not having a pattern in that case is OK because you cannot have a filter applied that early anyway. ;-)

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 517007 [details] [diff] [review]
extended patch [Checkin: comment 3]

Trying someone else for review in Gijs's absence.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 517007 [details] [diff] [review]
extended patch [Checkin: comment 3]

http://hg.mozilla.org/venkman/rev/57378c96755b