637915 - nsJNIString is leaky with zero length strings.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Doug Turner (:dougt)]

Attachment: v.1

nsJNIString is leaky with zero length strings.

Comment 2

[Doug Turner (:dougt)]

dup blocked.  this blocks.

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 516070 [details] [diff] [review]
v.1

Awesome. Just one nit.

>+    if (len <= 0) {
>+        SetIsVoid(PR_TRUE);
>+    }
>+    else {
>+        Assign(jCharPtr, len);
>+    }

The style in this file is to have else on the same line as the }.

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/d02b25c4b1a8

Comment 6

[jag (Peter Annema)]

Yay! Should I dupe bug 629604 against this then? I think there's still some
value to dropping the nsJNIString type and just using a helper function to
properly stuff the bits into an nsString.