637987 - IPDL protocols used in unit tests are always built, even without --enable-ipdl-tests

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This generates a bunch of C++ garbage (72 .o's) that's impossible to use in release builds.  I'm not sure what size all this code is when stripped all the way down, but I wouldn't be surprised if it's a few hundred KB worth.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Don't compile IPDL unit-test protocols when not asked to

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This might be a moderately tasty, free .apk size win; definitely worth checking.  If it's big might want to block on this.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Fired off a try run (ee4077a9df0b).  Not sure how closely the try builds correspond to what we release, but might be a reasonable estimate of savings.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

we'll block on figuring out how big the win is at least

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

"before-1/2" are the m-c tinderbox builds from around the time the cset my try push was based on.  "after" is the try build.  This doesn't control for m-b changes, but I doubt they contribute much to the .apk.

before-1: http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android-r7/1299004820/
before-2: http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android-r7/1299009445/
after: http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-ee4077a9df0b/try-mb-br-andrd-r7-bld/

-rw-r--r-- 1 cjones cjones 12565408 2011-03-01 23:46 before-1.apk
-rw-r--r-- 1 cjones cjones 12568143 2011-03-01 23:46 before-2.apk
-rw-r--r-- 1 cjones cjones 12474504 2011-03-01 23:46 after.apk

So looks like we might get a ~100KB reduction in .apk size.  Not too shabby.  Probably wouldn't block for this, but I'd really like to land it.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 516133 [details] [diff] [review]
Don't compile IPDL unit-test protocols when not asked to

Zero risk, saves 100KB off fennec download size and k times that much on install size.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/629de14f9ef9