637992 - blacklist pruning may rehash in midst of iteration (crash!)

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

The blacklist facility is useful when it works.

But it can currently break because in the loop of its pruning iteration, it calls GCHashtable::remove without overriding the default value for the rehash parameter.

This is really easy to fix.

(But better still to test the GCHashtable code more effectively by adding some debug state to fail-fast; will be filing separate bug for that shortly.)

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to comment #0)
> (But better still to test the GCHashtable code more effectively by adding some
> debug state to fail-fast; will be filing separate bug for that shortly.)

Filed as Bug 637993.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: simple patch

See 637993 for start of testing strategy

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 516146 [details] [diff] [review]
simple patch

(i considered making a selftest to illustrate, but i'm not certain that is reasonable to do so.  If prodded I will give it a shot.)

Comment 4

[Tamarin Bot]

changeset: 6032:4fc125271e47
user:      Felix S Klock II <fklockii>
summary:   Bug 637992: blacklist fix, delay pruning to post-iteration (r=treilly).

http://hg.mozilla.org/tamarin-redux/rev/4fc125271e47