638080 - Can't book flights on Virgin Blue website ($ is not defined error)

Status: RESOLVED INVALID

(Tech Evangelism Graveyard :: English Other, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

This may be TE, but:

STR:
1. Go to http://virginblue.com.au
2. Try to book a flight from Sydney to Perth
3. Select flights and press "Continue"

Expected: move on in flight booking flow
Actual:
------
Error: $ is not defined
Source File: http://book.virginblue.com.au/js/VirginBlue/virginBlueScript.js?v=43.8
Line: 1
------

(Also broken in Chromium Dev channel builds, but works in IE9)

Comment 1

[Jan de Mooij [:jandem]]

jquery-api.js has "use strict" and then includes some libraries like jQuery. This causes strict-mode errors:

[15:05:55.560] in strict mode code, functions may be declared only at top level or immediately within another function @ http://book.virginblue.com.au/js/VirginBlue/jquery-api.js:13

Comment 2

[Jan de Mooij [:jandem]]

Bug 630851 has more information on strict mode breaking websites.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Gotta love cargo-cultage!

Comment 4

[Lindsey]

I ran this by their twitter account, got back:

---
[...] thanks for this, as V4 is beta we haven't coded for it until final release

http://twitter.com/#!/VirginBlue/status/44980223195873280
---

Comment 5

[Boris Zbarsky [:bzbarsky]]

And gotta love that attitude....  ;)

Comment 6

[Mike Taylor [:miketaylr]]

It appears the site has changed since this report... so either INVALID or FIXED. Either way it works. :)