638088 - Hard-coded "or" in demos/submit

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[Staś Małolepszy :stas]

https://github.com/fwenzel/mdn/blob/master/apps/demos/templates/demos/submit.html#L179

Example: https://developer-stage9.mozilla.org/es/demos/submit

Is it possible to put the buttons into placables and do something like:

  "{{ submit }} or {{ discard }}"

?

If not, it should be fine to just do _("or"), with an appropriate comment:

{# L10n: displayed between the "Submit demo" button and the "Discard demo:" link #}

Comment 1

[Les Orchard [:lorchard]]

chowse might disagree, but I'm going to just take out the "or" for now, rather than make extra work for localizers. I think it works fine without it, and we can think about re-adding in a later release.

https://github.com/fwenzel/mdn/commit/249386b877afb567450fb6b366d7c8c1a9c3f54f

Comment 2

[Staś Małolepszy :stas]

Perfect, that definitely works for me! :)

Comment 3

[Guillermo Movia [:deimidis]]

It's work for es too

Comment 4

[Luke Crouch [:groovecoder]]

Agree. CC'ing Chowse for potential follow-up.