Open Bug 638102 Opened 10 years ago Updated 2 years ago
Lot of superfluous copies of vector<string> in Gecko
Child Process Host::Launch and helpers
We should be able to change all the helper functions (AsyncLaunch, SyncLaunch, PerformAsyncLaunch, etc) to take a reference to the vector instead. This would mean getting rid of the default arguments, but that should be fine. And maybe make them all private while we're at it? Looks like only Launch is called by external code.
Never mind--the top-level functions are getting called with default args, and PerformAsync launch is on a different thread, so needs a copy not a ref.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
:clangbot complained about this in bug 1401790 comment #2, because I happened to touch one of the lines where an unnecessary copy happens. It suggested adding a Move(), but I think we could go further and use rvalue references for (at least some of?) these parameters.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee: nobody → vskaulagi
Status: REOPENED → ASSIGNED
You need to log in before you can comment on or make changes to this bug.