638125 - adjust style of form assistant/findbar buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

They don't really work right now.  See here:

http://www.flickr.com/photos/madhava_work/5476945747/in/photostream/

Getting new styles from Sean today.

Comment 1

[Madhava Enros [:madhava]]

Actually, the field in the findbar shouldn't be transparent either.  You can get text showing through from below that looks like it's disabled gray text in the field.

Comment 2

[Madhava Enros [:madhava]]

From Sean via IRC:

mart3ll: vingtetun: http://grab.by/9kU8

mart3ll: same shape as now, same gradient as UI bg, arrows to 30% for disabled, stroke on buttons and field set at #383838

Comment 3

[Sean Martell]

http://grab.by/9kU8

- same shape as now
- same gradient as UI bg
- arrows to 30% for disabled
- stroke on buttons and field set at #383838

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Patched while bisecting!

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: form assistant screenshot

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: find helper screenshot

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 517783 [details] [diff] [review]
Patch

Looks nice!

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/f211b1225fe8

Comment 9

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110316 Firefox/4.0b13pre Fennec /4.0b6pre 

Devices: Motorola Droid 2(Android 2.2), Nokia N900 (Maemo GTK)