638132 - Integrate places, tracemonkey, electrolysis into the project_branch configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Get rid of more lines!

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: [tested] integrates places/jaegermonkey/electrolysis/tracemonkey into the project_branches.py & config loop

Ran dump masters on a build & test scheduler - no changes in output there, ran dump masters against a build & test master - no loss or gain in builders, slight change in that all branches have additional MOZ_SYMBOLS_EXTRA_BUILDID where they didn't before but that should be a non-issue.

Also passed test-masters.py

With regards to nightly update channels the workaround for this right now is that both tracemonkey and electrolysis will continue to use their mozconfigs from mozilla2/ since they exist already and if any future project branches want a custom nightly snippet channel then custom mozconfigs can be added as needed until we figure out another way to do this, otherwise any non-snippet project branch will use the generic mozconfigs.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 521691 [details] [diff] [review]
[tested] integrates places/jaegermonkey/electrolysis/tracemonkey into the project_branches.py & config loop

>+    if branchConfig.get('talos_suites'):
>+        talosConfig = branchConfig['talos_suites']
>+    else:
>+        talosConfig = {}
>+    for suite in SUITES.keys():
>+        if suite.startswith('remote-'):
>+            BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+        else:
>+            # 0 runs by default
>+            if suite in ('v8', 'addon', 'addon-baseline', 'cold'):
>+                if suite in ('cold'):

nit: this is clearer as "if suite == 'cold':", same below. (also, ('cold') expands to 'cold', so if we had a suite called 'old', this would get run. ('cold',) would have worked though)

I'd like to have these mapping set up elsewhere, so we don't have to reference these silly constants all over the place. That can wait for another time though!

>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), True, TALOS_DIRTY_OPTS, ALL_PLATFORMS)
>+                elif suite in ('addon'):
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), False, TALOS_ADDON_OPTS, ALL_PLATFORMS)
>+                elif suite in ('addon-baseline'):
>+                     BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), False, TALOS_BASELINE_ADDON_OPTS, ALL_PLATFORMS)
>+                else:
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), True, {}, ALL_PLATFORMS)
>+            else:
>+                # default is 1 run
>+                if suite in ('dirty'):
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 1), True, TALOS_DIRTY_OPTS, ALL_PLATFORMS)
>+                elif suite in ('tp4'):
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 1), True, TALOS_TP4_OPTS, ALL_PLATFORMS)
>+                elif suite in ('a11y'):
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 1), True, {}, NO_MAC)
>+                else:
>+                    BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 1), True, {}, ALL_PLATFORMS)

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 521691 [details] [diff] [review]
[tested] integrates places/jaegermonkey/electrolysis/tracemonkey into the project_branches.py & config loop

landed in default:

http://hg.mozilla.org/build/buildbot-configs/rev/c56c95c4f8c1

with nits addressed