Closed
Bug 638256
Opened 15 years ago
Closed 15 years ago
nanojit: remove LIR_xtbl
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(2 files)
|
20.56 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
|
770 bytes,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Bug 620757 changed TM so it no longer traces table switches. That means that support from them can be removed from Nanojit. I think this includes SwitchInfo and LIR_jtbl.
|
||
Comment 1•15 years ago
|
||
TR uses LIR_jtbl, but LIR_jtbl doesn't use SwitchInfo. LIR_xtbl does, and only on x86.
|
|
Assignee | |
Comment 2•15 years ago
|
||
My mistake, I meant LIR_xtbl all along! :)
Summary: nanojit: remove LIR_jtbl → nanojit: remove LIR_xtbl
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #516504 -
Flags: review?(edwsmith)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #516505 -
Flags: review?(dmandelin)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 516504 [details] [diff] [review]
NJ patch (against TM 62988:40f500ecdfd0)
Passed TR acceptance tests on mac x86 and x64, no surprises in patch.
Attachment #516504 -
Flags: review?(edwsmith) → review+
|
|
||
Updated•15 years ago
|
Attachment #516505 -
Flags: review?(dmandelin) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
http://hg.mozilla.org/projects/nanojit-central/rev/fd5ca562e1d1
http://hg.mozilla.org/tracemonkey/rev/68bd90f2aae1
http://hg.mozilla.org/tracemonkey/rev/de384e76ed18
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
|
|
Assignee | |
Comment 7•15 years ago
|
||
Apologies for omitting the bug number in the commit logs for the above patches :(
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•