63829 - Don't use nsMsgI18NEncodeMimePartIIStr in compose

Status: RESOLVED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David :Bienvenu]

nsMsgI18NDecodeMimePartIIStr is very inefficient since it creates a mime
converter every time you call it. The search session should cache a mime
converter and use it, and nsMsgI18NDecodeMimePartIIStr should be removed from
the source tree so no one ever calls it again.

Comment 1

[Sheela Ravindran]

Add names to cc list.
change qa contact->laurel,
reassing if not your area.

Comment 2

[(not reading, please use [e-mail] instead)]

as hwaara found, we could use a similar fix in nsMsgCompose.cpp

see http://lxr.mozilla.org/seamonkey/search?string=nsMsgI18NDecodeMimePartIIStr

Comment 3

[(not reading, please use [e-mail] instead)]

nsMsgI18NEncodeMimePartIIStr is no better.

we could change the API to force you to pass in mime converter.

then we could fix the callers.

Comment 4

[Håkan Waara]

working on this now... this could be a performance win for msgcompose

Comment 5

[John G. Myers]

I am in the middle of working on this now as well, for bug 65277.

Comment 6

[Håkan Waara]

Will bug 65277 fix this one as well? (Is my work on this redundant?)

Comment 7

[Håkan Waara]

reassigning back, I can't work on this; jgmyers is doing a lot of stuff in this
area and will probably fix this bug as well when his changes to bug 65277
 are landed.

Comment 8

[scottputterman]

reassigning to naving

Comment 9

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 10

[John G. Myers]

nsMsgI18NDecodeMimePartIIStr no longer exists.

Changing summary, was: 
Don't use nsMsgI18NEncodeMimePartIIStr / nsMsgI18NDecodeMimePartIIStr in search
or compose

Comment 11

[Mark Banner (:standard8)]

nsMsgI18NEncodeMimePartIIStr no longer exists as all. see
http://lxr.mozilla.org/seamonkey/search?string=nsMsgI18NDecodeMimePartIIStr

Therefore resolving as invalid. If you disagree, please reopen with reasons.