Closed
Bug 638291
Opened 14 years ago
Closed 14 years ago
remove obsolete JSMarkOp API, make JSTraceOp default
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
42.58 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
It was only used in two places: shell and the plugin API, I changed both to the new API.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Updated•14 years ago
|
Attachment #516449 -
Flags: review?(jorendorff)
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 516449 [details] [diff] [review]
patch
In modules/plugin/base/src/nsJSNPRuntime.cpp:
>-static uint32
>-NPObjectMember_Mark(JSContext *cx, JSObject *obj, void *arg)
>+static void
>+NPObjectMember(JSTracer *trc, JSObject *obj)
Looks like a typo here; should be NPObjectMember_Trace.
r=me with that and a post to m.d.t.js-engine about the change.
Attachment #516449 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 4•14 years ago
|
||
Follow-up fix to remove a stray ';'
http://hg.mozilla.org/tracemonkey/rev/d463a1ff1bdf
|
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a7784d11c59b
http://hg.mozilla.org/mozilla-central/rev/d463a1ff1bdf
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•