Closed Bug 638291 Opened 9 years ago Closed 9 years ago

remove obsolete JSMarkOp API, make JSTraceOp default

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

It was only used in two places: shell and the plugin API, I changed both to the new API.
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #516449 - Flags: review?(jorendorff)
Comment on attachment 516449 [details] [diff] [review]
patch

In modules/plugin/base/src/nsJSNPRuntime.cpp:
>-static uint32
>-NPObjectMember_Mark(JSContext *cx, JSObject *obj, void *arg)
>+static void
>+NPObjectMember(JSTracer *trc, JSObject *obj)

Looks like a typo here; should be NPObjectMember_Trace.

r=me with that and a post to m.d.t.js-engine about the change.
Attachment #516449 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/tracemonkey/rev/a7784d11c59b
Whiteboard: fixed-in-tracemonkey
Follow-up fix to remove a stray ';'

http://hg.mozilla.org/tracemonkey/rev/d463a1ff1bdf
Blocks: 639729
You need to log in before you can comment on or make changes to this bug.