release_sanity.py should define options.buildNumber as int

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
... otherwise the following line is True even if --build-number set to 1.
if options.buildNumber > 1:

>>> "1" > 1
True
(Assignee)

Comment 1

7 years ago
Created attachment 516572 [details] [diff] [review]
tools
Attachment #516572 - Flags: review?(bhearsum)
Comment on attachment 516572 [details] [diff] [review]
tools

You need to str()-ify this line:
http://hg.mozilla.org/build/tools/file/tip/buildbot-helpers/release_sanity.py#l181

r=me with that fixed on check-in.
Attachment #516572 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 627271
Depends on: 686263
No longer depends on: 686263
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.