Closed
Bug 638418
Opened 14 years ago
Closed 14 years ago
release_sanity.py should define options.buildNumber as int
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
... otherwise the following line is True even if --build-number set to 1.
if options.buildNumber > 1:
>>> "1" > 1
True
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #516572 -
Flags: review?(bhearsum)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 516572 [details] [diff] [review]
tools
You need to str()-ify this line:
http://hg.mozilla.org/build/tools/file/tip/buildbot-helpers/release_sanity.py#l181
r=me with that fixed on check-in.
Attachment #516572 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 516572 [details] [diff] [review]
tools
http://hg.mozilla.org/build/tools/rev/a9d9a12f592f
Attachment #516572 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•