638438 - online.nolife-tv.com - Using sort on the video lists doesn't work

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

On this site, pictures are used to submit forms for various buttons : LQ/HQ switch (available only for subscribed users, please contact us if you want a test account) and the sort buttons (red square buttons on top of the video list).

On Firefox 3.6 and Chrome it works, under Firefox 4.0b12 it doesn't work anymore.


Reproducible: Always

Steps to Reproduce:
1. Click on the sort buttons
2.
3.
Actual Results:  
Nothing

Expected Results:  
The list order should change.

Please contact me to get a test account if needed for the LQ/HQ switch. (for guests only LQ is available)

Comment 1

[Ed Morley [:emorley]]

Confirmed using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre ID:20110303122446

STR:
1) Visit http://online.nolife-tv.com/index.php?id=19662
2) Click the small red box (that's made up of two red triangles, back to back) above say the date column in the video list below the main flash video

Expected:
- Video list sorts and the red box transforms into a lighter colour triangle, indicating sort direction

Actual:
- Page reloads but no sort occurred / red box looks the same and hasn't changed to indicate sort direction

The only error in the error console is:

Error: Image corrupt or truncated: <unknown>
Source File: <unknown>
Line: 0

Using m-c...
Last good nightly: 2010-02-24 
First bad nightly: 2010-02-25
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ddfecbc93934&tochange=a29d44f196a6

Using tm...
Last good nightly: 2010-03-13 
First bad nightly: 2010-03-14
Pushlog: http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=0b28c109c213&tochange=6dae431c0018

Given the issue only occurs after m-c merges back to TM; presuming this isn't a TM problem and the large TM merges on the m-c range can be ignored.

First glance maybe implies bug 544698 could be at fault, so moving to Core:HTML Forms and CCing Jonas, but lots of other changesets there, so don't take as fact.

Leaving regressionwindow-wanted flag since the number of changesets in that 24hr range is huge, hoping someone (Alice?!) can be super awesome and build locally/use cached hourlies.

Comment 2

[Boris Zbarsky [:bzbarsky]]

hg bisect says:

The first bad revision is:
changeset:   38671:40326c4f714c
user:        Jonas Sicking <[e-mail]>
date:        Wed Feb 24 21:57:54 2010 -0800
summary:     Bug 547165: Add tests for form submission and fix a few cases where we differ from IE/HTML5. Also add a generic getMyDirectory.sjs file for use in other tests as well. r=benjamn/waldo

The relevant change there is probably that we used to submit the .x, .y, and bare name for image inputs, whereas per spec we should only submit .x and .y.

IE does the latter too.  Does this site work in IE?

Comment 3

[Ed Morley [:emorley]]

Just checked and it doesn't work in IE8 either; albeit I don't have the activeX version of Flash installed, but presuming that's not going to affect the list sort below the main video anyway.

TE then?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> but presuming that's not going to affect the list sort below the main video

It doesn't; I was doing my testing with Flash disabled.

This site is just broken.

Comment 5

[[e-mail]]

I have more information : It seems the problem lies in the fact that FF4b12 doesn't return the "value" attribute when submitting the form. It did in FF3.6. I can't find anything in the HTML5 specs specifying that "value" isn't to be returned when the <input> type is "image".

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

From http://dev.w3.org/html5/spec/Overview.html#constructing-form-data-set

Step 3:

3. If the field element is an input element whose type attribute is in the Image Button state, then run these further nested substeps:

Substeps 5-7:

5. Append an entry to the form data set with the name namex, the value x, and the type type.

6. Append an entry to the form data set with the name namey and the value y, and the type type.

7. Skip the remaining substeps for this element: if there are any more elements in controls, return to the top of the loop step, otherwise, jump to the end step below


So it appends name.x and name.y and then nothing else. Specifically, it skips main step 9 which is where the name=value part is added.

Comment 7

[Ed Morley [:emorley]]

It's in TE, is resolved invalid correct?

Comment 8

[[e-mail]]

Okay Jonas, looks like "value" was allowed for <input type="image"> in HTML4 but no more in HTML5.

What I found was actually :
http://dev.w3.org/html5/spec/Overview.html#the-input-element
Looks like there's a mistake there, the table that summarizes which attribute apply to each type of input shows that "value" applies to the Image Button type.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

(In reply to comment #7)
> It's in TE, is resolved invalid correct?

My bad, right you are.

(In reply to comment #8)
> Okay Jonas, looks like "value" was allowed for <input type="image"> in HTML4
> but no more in HTML5.

Actually, HTML4 is horribly ambiguous. You can interpret it in lots of different ways. Generally speaking HTML4 is no longer very relevant for the web, pages often depend in things undefined in HTML4 or defined contrary in HTML4. I haven't used HTML4 as a reference for a long time for what to do in Firefox.

I recommend looking in HTML5 instead.

> What I found was actually :
> http://dev.w3.org/html5/spec/Overview.html#the-input-element
> Looks like there's a mistake there, the table that summarizes which attribute
> apply to each type of input shows that "value" applies to the Image Button
> type.

Would be great if you could file a bug on the HTML5 spec in the W3C bugzilla.

Comment 10

[Ed Morley [:emorley]]

Lambin, for reference: http://www.w3.org/Bugs/Public/

Comment 11

[Mounir Lamouri (:mounir)]

CCing Paul who knows some people at NoLife I think.

Comment 12

[Paul Rouget [:paul]]

NoLife contacted.

Comment 13

[Karl Dubost💡 :karlcow]

Is it still going on? If no let's close it.

Comment 14

[[e-mail]]

I don't know, the site was revamped a few years ago so I can't reproduce the bug anymore.

Comment 15

[Karl Dubost💡 :karlcow]

Thanks lambin.