638525 - The "Edit article based on this revision" option should automatically bring summary and keywords from the previous revision to the new revision

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Underpass]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: 

As for the subject. Now by now, it is impossible to save a revision without a summary and if you edit a revision clicking "Edit article based on this revision", you are forced to write keywords and summary again

Reproducible: Always

Comment 1

[James Socol [:jsocol, :james]]

On support.allizom.org, I went to "Qu'est-ce que Panorama", went into the history, and edited based on a previous revision. The keywords and summary field were filled in already. Do you have a different set of STR?

Comment 2

[Underpass]

I just made a fake edit on "https://support.allizom.org/it/kb/Si è verificato un arresto anomalo del plugin Adobe Flash" and got the problem again.

Probably this issue is verified on articles that do not have already a summary (i.e. migrated from tiki but untouched).

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> Probably this issue is verified on articles that do not have already a summary
> (i.e. migrated from tiki but untouched).

In that case, we're using the correct summary and keywords for the given revision: none. The summary, at least, will need to be added.

Comment 4

[Underpass]

Sorry jsocol, "none" IMHO is not the correct summary for the given revision: if I create a summary for the first revision I expect that this summary is used on every subsequent revision obtained from the first one.

Am I wrong?

Comment 5

[James Socol [:jsocol, :james]]

You said that this only happened on articles that were migrated with no summary, correct? So if you base an edit on a revision that has no summary, which can only happen if it was migrated, we are showing you the summary from that revision.

Are you able to start an edit based on a revision that _does_ have a summary, and still get an empty summary in the form? That would be a bug.

Comment 6

[Underpass]

That's what I'm saying... :)

If I create a revision *but without approving it* I am still forced to fill the keyword and summary fields.

But if I create a subsequent revision from that one *still not yet approved*, keywords and summary are lost.

Comment 7

[Kadir Topal [:atopal]]

I can confirm. So, even if you give it a summary and submit it, the "edit based on this revision" feature only picks up the body text, not the summary or keywords.

Simone, I checked and this seems to work now on allizom.org.
James, maybe this was fixed in 2.6.2?

Comment 8

[Underpass]

Kadir, I just checked on https://support.allizom.org and the problem still exists. I leave the steps to reproduce it

1) Pick any article
2) Apply a minor or no change but do make some change in the summary
3) Save the revision without approving it
4) Open the saved revision and click on "Edit article based on this revision"
5) You will not get the summary from the last revision but only the summary from the original article (if it has already one) or no summary at all (if it is migrated from Tiki but untouched since then).

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

landed on master:
https://github.com/jsocol/kitsune/commit/60af826a803384873bcc96334879abb73ca6d0d0

Comment 10

[Rebecca Billings [:rbillings]]

Verified that editing an article based on an unapproved revision displays the edited summary