638577 - Reflect.parse doesn't handle doubly-declared functions gracefully

Status: ASSIGNED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Possibly a duplicate of bug 632030.

var a = Reflect.parse(
            "function f() { return 1; } function f() { return 2; }",
            {loc: false});
a.body[0].toSource() === a.body[1].toSource()   // true

No matter what's in the two function bodies, we get the same FunctionDeclaration twice.

This quirk never causes Reflect.parse to return a "wrong" AST in the sense of having different program behavior, but it's odd enough that it breaks a test (see patch in bug 630232).

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 638577 - Restore commented out tests r=nbp

The test commented out in bug 630232 now passes.

Bug 591450 is closed but failed to uncomment its test, so I'm uncommenting it
here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/877508168f75
Restore commented out tests r=nbp