Last Comment Bug 638647 - Remove unused AfterHighlightColorChange function from editor.js
: Remove unused AfterHighlightColorChange function from editor.js
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Composer (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-03 17:27 PST by Ian Neal
Modified: 2011-03-04 10:44 PST (History)
1 user (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove unused AfterHighlightColorChange function v1.0 [Checked in: Comment 3] (1.13 KB, patch)
2011-03-03 17:27 PST, Ian Neal
neil: review+
Details | Diff | Review

Description Ian Neal 2011-03-03 17:27:05 PST
Created attachment 516756 [details] [diff] [review]
Remove unused AfterHighlightColorChange function v1.0 [Checked in: Comment 3]

The function AfterHighlightColorChange was never used even when originally added in bug 77705 so should probably be removed.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2011-03-03 19:07:58 PST
Ian, please file bugs specific to the SeaMonkey Composer component in SeaMonkey::Composer.  Core::Editor is for the Gecko editor component.

Thanks!
Comment 2 neil@parkwaycc.co.uk 2011-03-04 09:24:53 PST
Comment on attachment 516756 [details] [diff] [review]
Remove unused AfterHighlightColorChange function v1.0 [Checked in: Comment 3]

Looks like onHighlightColorChange gets to do the work via goUpdateCommand("cmd_highlight") in EditorSelectColor.
Comment 3 Ian Neal 2011-03-04 10:44:24 PST
Comment on attachment 516756 [details] [diff] [review]
Remove unused AfterHighlightColorChange function v1.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/f2f42e0e284d

Note You need to log in before you can comment on or make changes to this bug.