638762 - post_signing poller should look for full url

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris AtLee [:catlee]]

On 4.0rc1 the post_signing poller didn't fire because it was looking at http://stage-old.mozilla.org/pub/mozilla.org/firefox/nightly/4.0rc1-candidates/build1/ and then looking at the contents to see if the signing log was present.

We had however created an index.html file in that directory to prevent casual eyes from finding the builds. This also made it so the poller didn't see the signing log.

The poller should be looking for the exact URL of the signing log.

Comment 1

[Rail Aliiev [:rail]]

Attachment: Use full URL for FtpPoller

Not tested yet.

Comment 2

[Rail Aliiev [:rail]]

Attachment: UrlPoller

* removed InvalidResultError and EmptyResult classes (not used, copy paste from somewhere)
* added compare_attrs for safer reconfigs
* Added and used UrlPoller class which:
 * not hammering ftp, polls until it gets the URL, then stops the loop
 * simpler (imo) twisted style logic

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 517408 [details] [diff] [review]
UrlPoller

We aware that changing the compare_attrs for FtpPoller might make it tricky to land this change as a reconfig (http://trac.buildbot.net/ticket/1791).  May have to do one reconfig to disable all release objects, and then a 2nd reconfig to re-enable them with the new FtpPoller code.

Comment 4

[Rail Aliiev [:rail]]

Attachment: UrlPoller

* refreshed patch
* added import buildbotcustom.changes.ftppoller and reload(buildbotcustom.changes.ftppoller) to make changes reconfigurable

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 518119 [details] [diff] [review]
UrlPoller

http://hg.mozilla.org/build/buildbotcustom/rev/71c3b08582a2