638846 - enable crashtest, jsreftest on tegras

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Blocked on issues with remotereftest.py.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: enable crashtest and jsreftest

Joel advised me that it's best to run the jsreftest tests in 2 chunks, too.

Haven't been able to verify this in staging, because all of the foopy02 tegras are dead :(

This patch fixes bug 638844 too.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 518716 [details] [diff] [review]
enable crashtest and jsreftest

r=me, as this patch looks correct to re-enable crashtest and enable jsreftest in 2 chunks.

However, as of yesterday morning's quick meeting with bear/coop/joduinn/me, we heard that reftests were potentially taking out tegras in the production pool, so I'd rather not enable in production until we figure out what's going on.

If {jsref,ref,crash}tests all run in staging cleanly without a larger-than-expected lossage of tegras, let's turn 'em on.  Otherwise turning off reftests and waiting for a fix might be a better immediate solution.

Comment 3

[Mike Taylor [:bear]]

taking bug to land and enable in new production pools

Comment 4

[Mike Taylor [:bear]]

Comment on attachment 518716 [details] [diff] [review]
enable crashtest and jsreftest

committed changeset 3865:d892db03a7fb

landed on default, will post when merged to production

Comment 5

[Aki Sasaki (not active)]

Attachment: attaching a reftest patch because i'm a rebel

per discussion in irc (for joel)

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 523364 [details] [diff] [review]
attaching a reftest patch because i'm a rebel

http://hg.mozilla.org/build/buildbot-configs/rev/8781a228b71b

Comment 7

[Mike Taylor [:bear]]

Attachment: add config.py step to switch tegra resolution

Comment 8

[Mike Taylor [:bear]]

Attachment: add config.py step to switch tegra resolution

moved new step to top of routine to avoid having two identical pieces of code in the if/elif section

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 523381 [details] [diff] [review]
add config.py step to switch tegra resolution

This could also go above the 'for suite in' line, but I don't particularly care.
This looks good, and I think config.py's testname check will work out of the box, so r=me.

Comment 11

[Mike Taylor [:bear]]

Comment on attachment 523381 [details] [diff] [review]
add config.py step to switch tegra resolution

committed changeset 1449:f56862ba640b

Comment 12

[Mike Taylor [:bear]]

moved to production by changeset 157a12ba4a76

Comment 13

[Mike Taylor [:bear]]

marking as resolved - crashtest run has a configure devices step (and it worked!)