Rationalise popups into utilityOverlay.xul

ASSIGNED
Assigned to

Status

SeaMonkey
General
ASSIGNED
7 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 517165 [details] [diff] [review]
Rationalise into utilityOverlay.xul patch v1.0

At the moment we have the following littered over various files in various places and they could be consolidated into a single popupset within utilityOverlay.xul:
<menupopup id="sidebarPopup"/>
<menupopup id="popupNotificationMenu"/>
<menupopup id="toolbar-context-menu"/>
<panel id="customizeToolbarSheetPopup"/>
Attachment #517165 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 517165 [details] [diff] [review]
Rationalise into utilityOverlay.xul patch v1.0

<menupopup id="sidebarPopup"/>
Part of the sidebar, not really part of utilityOverlay. Not all windows have a sidebar (yet), only navigator, editor and compose. (And yet editor lacks the popup. Oops.)

<menupopup id="popupNotificationMenu"/>
Only needed in navigator and windows with a sidebar, since it handles the popup blocker notifications. I guess I only put it in utilityOverlay out of laziness.

<menupopup id="toolbar-context-menu"/>
<panel id="customizeToolbarSheetPopup"/>
These would be good candidates, but there are only two, which makes it seem less worthwhile. So I'm looking for feedback from Mnyromyr to see whether it's worth referencing all four popups in all windows.
Attachment #517165 - Flags: feedback?(mnyromyr)

Comment 2

7 years ago
Comment on attachment 517165 [details] [diff] [review]
Rationalise into utilityOverlay.xul patch v1.0

Looking at <http://mxr.mozilla.org/comm-central/search?string=utilityOverlay.xul&find=suite%2F.*xul%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central>, I'm not so sure that spreading the sidebar stuff to all those windows is that useful…
Attachment #517165 - Flags: feedback?(mnyromyr) → feedback-

Updated

7 years ago
Attachment #517165 - Flags: review?(neil) → review-
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> Comment on attachment 517165 [details] [diff] [review]
> Rationalise into utilityOverlay.xul patch v1.0
> 
> Looking at
> <http://mxr.mozilla.org/comm-central/search?string=utilityOverlay.xul&find=suite%2F.*xul%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central>,
> I'm not so sure that spreading the sidebar stuff to all those windows is that
> useful…

Surely it would only spread stuff into windows that have the hook for popupset utilityOverlaySet in?

Comment 4

6 years ago
IanN are you still working on this?
You need to log in before you can comment on or make changes to this bug.