639204 - Fix link with xcode 4

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It looks like the linker in xcode 4 is picky about how one should compute the GOT. This patch changes the assembly in webm to use the same sequence used by the compilers. Without it I get a link error on the 32 bit libxul.

The sequence is simpler anyway. I did some basic tests by playing webm movies on youtube.

I will send this upstream as soon as I get the agreement sorted out.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

Comment 2

[(no longer active)]

Rafael, did you mean to ask for review?

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

I assumed this should go upstream first, so I was waiting for the paperwork for the contributor agreement.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

This is
http://review.webmproject.org/#change,1964

Comment 5

[Josh Aas]

Looks like this has merged upstream, who should review here?

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The upstream commit is 52f6e28e9e5e176424c1c65ff13aa57abf9c00e6. Do we normally port individuals patches or do full merges of libvpx?

Comment 7

[Timothy B. Terriberry (:derf)]

I'm probably the one who should review this. We do full merges of libvpx at periodic intervals, and port individual patches in the meantime. See https://wiki.mozilla.org/WebM/Updating_libvpx and the update.sh script in media/libvpx for details. I.e., if you want to add this as an individual patch, there should be a .patch file in media/libvpx that applies against the current in-tree version (0.9.5) and is included in the update.sh script (also in that directory).

Comment 8

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Upadated update.sh

http://tbpl.mozilla.org/?tree=MozillaTry&rev=0a15ed5368dc

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/7b9f40070259

Comment 10

[u279076]

Can someone confirm this as fixed?

Comment 11

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Yes, I can now build with the xcode4 linker.