639214 - Ask for something other than an email address in the comment form

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

The other week, I got a new phone, and as one does, the first thing I did with it was star a build. To my shock and horror, when I went to fill out the email field in the comment popup, I had to click three times to put in the "@", rather than the once that would have been all I needed if we used type="email".

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 517173 [details] [diff] [review]
Fix

r=me

But you should note that it's not going to be possible anymore to set something else than an email like a IRC nickname. I don't know if a lot of people were doing that but I know I didn't change the type to email when I've added required to prevent that.

Comment 2

[Markus Stange [:mstange]]

Yeah, what do people think of renaming the field to IRC nickname?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Yeah, what do people think of renaming the field to IRC nickname?

I only use my irc nickname in there, I don't see the need for an email address.

Comment 4

[Mounir Lamouri (:mounir)]

The email address is a sensitive and private information. It sounds better to ask for a name or nickname that would help recognize the author of the starring if needed.

Comment 5

[Jeff Walden [:Waldo]]

I've only ever put my address with a % in there, myself.  IRC nick sounds like a good change to me, would avoid any need for the user to consider "I should obfuscate or lie here".

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Minimal "Name/nick"

We could thrash around through the whole thing, changing every instance of "email" to "nick" but I'm really not that excited about it - the part where we don't wrap an "<a href=spamto:" around it is the only useful part.

Comment 7

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/9719c54ff703

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Is there a follow-up/related bug to change how tinderbox actually generates the note HTML snippet?

Comment 9

[Phil Ringnalda (:philor)]

I doubt it - most people don't bother filing Tinderbox bugs unless they plan on fixing them themselves, and virtually nobody ever plans on fixing Tinderbox bugs.

If you look at http://tinderbox.mozilla.org/SeaMonkey/notes.txt, you'll see that people have been refusing to give Tinderbox an email address, and it has happily been creating "<a href="mailto:bryner">," for at least eight years.