Closed Bug 639227 Opened 9 years ago Closed 9 years ago

one trace hook is enough, really

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

We have a trace hook in ObjectOps and one in JSClass. non-native objects always also have a specific class, so we can as well always use that hook.
Attached patch patch (obsolete) — Splinter Review
Assignee: general → gal
Attached patch patch (obsolete) — Splinter Review
Attachment #517180 - Attachment is obsolete: true
Attached patch patchSplinter Review
Note that this is not an API change.
Attachment #517181 - Attachment is obsolete: true
http://hg.mozilla.org/tracemonkey/rev/68352f572399
Whiteboard: fixed-in-tracemonkey
Re-landed with a tiny fix (class trace hook has to be triggered for non-native objects too of course).

http://hg.mozilla.org/tracemonkey/rev/5e8744f7c31a
Blocks: 639729
http://hg.mozilla.org/mozilla-central/rev/5e8744f7c31a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.