Port |Bug 619013 - Wording in Update Sync Key dialog needs to be more clear|

RESOLVED FIXED in seamonkey2.1b3

Status

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b3
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 b3+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch (obsolete) — Splinter Review
This logically depends on bug 634419 which introduces Easy Setup and with that the concept of devices. This can be reviewed independently easily but must not land before bug 634419.

Since this is about string changes it needs to block b3.
Attachment #517280 - Flags: review?(iann_bugzilla)
Comment on attachment 517280 [details] [diff] [review]
patch

>+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
Perhaps "from" instead of "using"?
r=me with that addressed / fixed.
Attachment #517280 - Flags: review?(iann_bugzilla) → review+
blocking-seamonkey2.1: ? → b3+
this is blocking b3, and has review.

More to do, or free-to-land?
(In reply to comment #2)
> More to do, or free-to-land?

See comment 0!
(In reply to comment #1)
> >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> Perhaps "from" instead of "using"?

Changed locally.
(In reply to comment #4)
> (In reply to comment #1)
> > >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> > Perhaps "from" instead of "using"?
> 
> Changed locally.

To bikeshed, I personally find "using" better. Though I have reasoning to back it up. Using announces that it was with clear _user_ choice, where "from" might make me think that another device did it without me and confuse me.
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #1)
> > > >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> > > Perhaps "from" instead of "using"?
> > 
> > Changed locally.
> 
> To bikeshed, I personally find "using" better. Though I have reasoning to back
> it up. Using announces that it was with clear _user_ choice, where "from" might
> make me think that another device did it without me and confuse me.

Either of using / from suggests that, for it to be clear user choice it would be:
"You changed your Sync Key using (or from) another device, please enter your updated Sync Key."
(In reply to comment #6)
> "You changed your Sync Key using (or from) another device, please enter your
> updated Sync Key."

Jens asked me on irc about my opinion, and I think the above sounds good - with "from". Just my 0.1 SEK (which is 1 "Öre").
What Ian and Stefan said
Attachment #517280 - Attachment is obsolete: true
Attachment #522766 - Flags: review+
Comment on attachment 522766 [details] [diff] [review]
patch v1a [Checkin: comment 9]

http://hg.mozilla.org/comm-central/rev/7410fb8132ba
Attachment #522766 - Attachment description: patch v1a → patch v1a [Checkin: comment 9]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
(In reply to comment #7)
> Just my 0.1 SEK (which is 1 "Öre").

Whoops, it's not - it's 10 öre!
No longer blocks: 615950
You need to log in before you can comment on or make changes to this bug.