639339 - Port |Bug 619013 - Wording in Update Sync Key dialog needs to be more clear|

Status: RESOLVED FIXED

(SeaMonkey :: Sync UI, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

This logically depends on bug 634419 which introduces Easy Setup and with that the concept of devices. This can be reviewed independently easily but must not land before bug 634419.

Since this is about string changes it needs to block b3.

Comment 1

[Ian Neal]

Comment on attachment 517280 [details] [diff] [review]
patch

>+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
Perhaps "from" instead of "using"?
r=me with that addressed / fixed.

Comment 2

[Justin Wood (:Callek)]

this is blocking b3, and has review.

More to do, or free-to-land?

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #2)
> More to do, or free-to-land?

See comment 0!

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #1)
> >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> Perhaps "from" instead of "using"?

Changed locally.

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #4)
> (In reply to comment #1)
> > >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> > Perhaps "from" instead of "using"?
> 
> Changed locally.

To bikeshed, I personally find "using" better. Though I have reasoning to back it up. Using announces that it was with clear _user_ choice, where "from" might make me think that another device did it without me and confuse me.

Comment 6

[Ian Neal]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #1)
> > > >+new.synckey2.introText       = Your Sync Key was changed using another device, please enter your updated Sync Key.
> > > Perhaps "from" instead of "using"?
> > 
> > Changed locally.
> 
> To bikeshed, I personally find "using" better. Though I have reasoning to back
> it up. Using announces that it was with clear _user_ choice, where "from" might
> make me think that another device did it without me and confuse me.

Either of using / from suggests that, for it to be clear user choice it would be:
"You changed your Sync Key using (or from) another device, please enter your updated Sync Key."

Comment 7

[Stefan [:stefanh]]

(In reply to comment #6)
> "You changed your Sync Key using (or from) another device, please enter your
> updated Sync Key."

Jens asked me on irc about my opinion, and I think the above sounds good - with "from". Just my 0.1 SEK (which is 1 "Öre").

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v1a [Checkin: comment 9]

What Ian and Stefan said

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 522766 [details] [diff] [review]
patch v1a [Checkin: comment 9]

http://hg.mozilla.org/comm-central/rev/7410fb8132ba

Comment 10

[Stefan [:stefanh]]

(In reply to comment #7)
> Just my 0.1 SEK (which is 1 "Öre").

Whoops, it's not - it's 10 öre!