639455 - Reference to communicator skin from inspector skin

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Both classic and modern Inspector themes reference a single image from communicator. KaiRo recently renamed this image in the Classic theme, thus breaking Inspector even more (given that it was already broken for other apps).

Options:
1. Do away with the image entirely. (Personally I don't like this.)
2. Don't theme the image in Inspector; make SeaMonkey do it.
3. Copy a suitable image into Inspector. (For Modern this would presumably be
   the existing image, but I don't know what to say for Classic.)

Comment 1

[Javi Rueda :javirid]

Can't we reference to the new image name?

Also, what is the image name that was changed?

Comment 2

[[e-mail]]

I have created the URL to search for communicator resources in inspector skin.

Referencing the new image name will still only work in SeaMonkey...

Comment 3

[Javi Rueda :javirid]

Replacing the name with the new file one works, as expected, in Seamonkey. In Firefox there is no "Modern theme" menu item, but installing "Past Modern Revisited" by Lootyhoof from the Theme Repository works as well.

In the Classic (default) theme it will not work, though.

Comment 4

[Javi Rueda :javirid]

On SeaMonkey I've got it working by referencing the navigator theme in the inspectorWindow.css file, removing the reference to the graphic file and changing the class of the <image> in the toolboxOverlay.xul file to point to #page-proxy-button so SeaMonkey theme it.

Probably this is not the best class, so I am going to check for the other ones in navigator.css.

All this changes doesn't work in Firefox, though, as Neil noted.

Comment 5

[Javi Rueda :javirid]

Attachment: patch

This shows the bookmark item icon defined in every skin for SeaMonkey and Firefox.

Inspector main window now uses the corresponding skin.

Comment 6

[[e-mail]]

Comment on attachment 612670 [details] [diff] [review]
patch

Well, that's certainly an interesting approach, but I can't decide whether I like it, so I'm going to have to defer to Colby on this I'm afraid.

>-            <image id="imgURLBarIcon"/>
>-
>+	    <image class="bookmark-item"/>
Nit: your editor changed 8 spaces to a tab, which is wrong.
I think we should keep the id, in case there are third-party themes using it.

Comment 7

[Javi Rueda :javirid]

Attachment: corrected patch

Corrected patch with tab replaced by spaces (sorry about that) and keeping the id while adding the class.

Comment 8

[Javi Rueda :javirid]

Attachment: corrected patch

Ups.

Comment 9

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 612973 [details] [diff] [review]
corrected patch

Review of attachment 612973 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.

Comment 10

[Colby Russell :crussell (no longer Mozilla-ing)]

Pushed:
http://hg.mozilla.org/dom-inspector/rev/a8ea286ae21f

Comment 11

[Javi Rueda :javirid]

You welcome, Colby.