639527 - Include a last updated timestamp in the blocklist.xml

Status: VERIFIED FIXED

(Toolkit :: Blocklist Policy Requests, defect, P4)

Description

[Dave Townsend [:mossop]]

To facilitate bug 639524 I'd like the blocklist service to start including a timestamp of when it was last updated. This can either be the last time any changes were made to it or simpler just the time the xml was retrieved (the former is probably more complicated to program but caches better).

I'd see this appearing on the root blocklist element as:

<blocklist lastupdate="<ms since epoch>">

Comment 1

[Wil Clouser [:clouserw]]

jbalogh just redid the blocklist in zamboni, so we can add this.  It won't go live until the new blocklist does (after fx4).

Comment 2

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/5cdbb9e 

This looks like:

<blocklist xmlns="http://www.mozilla.org/2006/addons-blocklist" lastupdate="{{ now }}">

and will eventually show up on https://addons.allizom.org/z/blocklist/3/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/4.0/.

Comment 3

[Dave Townsend [:mossop]]

Ugh I just realised I made a big mistake here. The code that automatically pulls the blocklist into mozilla-central will always think that it has changed if the date is always changing. We either need to fix the code that does the import to ignore the date change (is that available somewhere for me to try to fix?), or make this date only change when the DB changes (hard I'm guessing), or back this out :(

Comment 4

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/d98ad45

Comment 5

[krupa raj[:krupa]]

Attachment: screenshot

STR:

1. Add a new blocklistitem
2. Change extensions.blocklist.interval to 60 and reset app.update.lastUpdateTime.blocklist-background-update-timer
3. restart Firefox
4. Check blocklist.xml

expected behavior:
blocklist.xml has last updated timestamp

actual behavior:
blocklist.xml  does not have the last updated timestamp

Comment 6

[Wil Clouser [:clouserw]]

Your screenshot doesn't show the XML at all.  I see a lastupdate attribute on the URL in comment 2.

Comment 7

[Jeff Balogh (:jbalogh)]

I'm not interested in what firefox does when it sees my blocklist.xml. All I care about is what's in https://addons.allizom.org/z/blocklist/3/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/4.0/.

Comment 8

[krupa raj[:krupa]]

verified by checking the page source @ https://addons-next.allizom.org/z/blocklist/3/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/4.0/

Comment 9

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 10

[Dave Townsend [:mossop]]

Why doesn't this seem to be live?

Comment 11

[Wil Clouser [:clouserw]]

The blocklist code that is live is still running on PHP.  We're waiting on QA to sign off on the new code in bug 640230 before enabling it.  You should post there if it's blocking you on something.