63957 - keyboard modifiers for clicking links should also apply when selecting link and pressing enter

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Jesse Ruderman]

If a link is focused, shift+enter should save the link target, ctrl+enter 
should open it in a new window, etc.  Currently, those key combinations don't 
do anything in Mozilla when a link is selected.

Works in IE with shift+enter on a link (open link in new window).  Doesn't work 
in NS 4.x with shift+enter (save link as...).

This should apply to future shortcuts for links as well as current ones.  It 
should probably also apply to form-submit buttons once "submit form in new 
window" is available, but that could get trickier because ctrl+enter in a form 
and ctrl+space have other meanings.

Comment 1

[Alec Flett]

cool idea, but marking future

Comment 2

[Blake Ross]

Alec, taking this if you don't mind...

Comment 3

[Aaron Leventhal]

Ctrl+enter or Accel+enter?

Comment 4

[Aaron Leventhal]

We've had some discussions recently about when accel should be used, and when
ctrl/alt/cmd should be specified explicitly. The results of our thoughts are in
the keyboard FAQ: www.mozilla.org/accessibility/ui/mozkeyintro.html

Accel should be specified for letters and number combos. Exact modifiers should
be specified for everything else (function keys, home, end, pgup, pgdn, space,
enter, space, punctuation, tab). For example, this is consistent with the fact
that Alt+Left and Alt+Right stays constant for prev/next page on UNIX,
regardless of your accel key setting.

Therefore, Ctrl+Enter should be the key used here.

Comment 5

[Aaron Leventhal]

It would great if this bug would also take into account bug 42557.
Ctrl+Shift+Click/Cmd+Shift+Click to open in window behind the current one.

Comment 6

[Jesse Ruderman]

> Ctrl+enter or Accel+enter?

Depends on whether Ctrl+click or Accel+click opens a link in a new window...

Comment 7

[Matthew T (active 1999-2002)]

Should be accel+Enter to open the focused link in a new window, not
Control+Enter -- since it's Command+click (not Control+click) which opens a 
link in a new window in Mac OS.

Comment 8

[Aaron Leventhal]

It's not accel+Enter.

It's Cmd+Enter on Mac, Ctrl+Enter on everything else.

Accel is only used with alphanumeric keys to specify the modifier.
For all other keys, we specify the exact modifier for each platform.
For example, Alt+Left doesn't change depending on how you have your accel key 
settings.

See www.mozilla.org/projects/ui/accessibility/mozkeyintro.html for more detail

Comment 9

[Jesse Ruderman]

Shift+enter (save link) works now, but Ctrl+enter (open link in new window)
still doesn't do anything.

Comment 10

[Blake Ross]

usability/polish 0.9.4.

Comment 11

[Blake Ross]

Ctrl+enter does not work on Windows, see for example the 'ctrl+enter should send
message' bug.  I'm marking this fixed, but if it doesn't work on other platforms
besides Windows, feel free to reopen.

Comment 12

[sairuh (rarely reading bugmail)]

tested using 2001.11.08.0x-comm bits on linux rh6.2, winnt and mac os 10.1;
here's what i see:

Mac 10.1:
shift+return/shift+enter for focused link: does nothing
cmd+return/cmd+enter for focused link: opens link in new window

WinNT:
shift+enter: saves link [brings up file picker]
ctrl+enter: does nothing [as blake pointed out]

Linux rh6.2:
shift+enter: saves link [brings up file picker]
ctrl+enter: opens link in new window

since this issue appears fixed only on linux, am gonna reopen. blake, reassign
as needed!

Comment 13

[selmer (gone)]

Doesn't seem like an enhancement can be critical to 096 at this point.  Please
retarget appropriately.

Comment 14

[selmer (gone)]

No response, resetting target milestone to ---.  Please pick a new target
milestone when you get back to this.

Comment 15

[Blake Ross]

So the only thing that unexpectedly doesn't work is save on the mac?  Wouldn't
that basically be bug 55686?

Comment 16

[Blake Ross]

reclosing.

Comment 17

[sairuh (rarely reading bugmail)]

okidoke!