639573 - addon tests should be prioritized lower than all others

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

We already run this at an off peak time, but there's no reason we shouldn't prioritize them lower than even try builds, since generally, nobody is waiting on results.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: change branch priorities

Refactor branch priorities a bit, de-prioritize addon branches.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 517490 [details] [diff] [review]
change branch priorities

>diff --git a/mozilla/master_common.py b/mozilla/master_common.py
>index 68c2cab..3df0d4e 100644
>--- a/mozilla/master_common.py
>+++ b/mozilla/master_common.py
>@@ -15,9 +15,14 @@ c['schedulers'] = []
> c['change_source'] = []
> 
> # Builders from these branches are given higher priority.
>-PRIORITY_BRANCHES = ['mozilla-central',
>-                     'mozilla-1.9.2',
>-                     'mozilla-1.9.1']
>+BRANCH_PRIORITIES = {
>+    'mozilla-central': 1,
>+    'mozilla-2.0': 1,
>+    'mozilla-1.9.2': 1,
>+    'mozilla-1.9.1': 1,
>+    'addontester': 4,
>+    'addonbaselinetester': 4,
>+}
> 
> # Give the release builders priority over other builders
> def prioritizeBuilders(botmaster, builders):
>@@ -38,8 +43,8 @@ def prioritizeBuilders(botmaster, builders):
>             priority = 0
>         elif builder.properties and \
>              builder.properties.has_key('branch') and \
>-             builder.properties['branch'] in PRIORITY_BRANCHES:
>-            priority = 1 
>+             builder.properties['branch'] in BRANCH_PRIORITIES.keys():
>+            priority = BRANCH_PRIORITIES[builder.properties['branch']]

weird indentation here

does adding try to the list above work? then we could get rid of the clause below

>         elif builder.builder_status.category.startswith('try'):
>             priority = 3
>         else:

Comment 3

[[e-mail] (:bhearsum)]

Good points, I'll address them both on check-in.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: v2

I ended up needing to change this a bit more to get try supported properly. Branches for mobile are $mozilla-$mobile, so it's a bit more work to figure out which priority to use.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 518050 [details] [diff] [review]
v2

Landed on default: changeset:   4195:c28b33113f59

Comment 6

[[e-mail] (:bhearsum)]

Attachment: bustage fix

This should fix the Traceback from preproduction. The problem is that priority can be unassigned if the branch property exists, but isn't matched anywhere in BRANCH_PRIORITIES.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 518353 [details] [diff] [review]
bustage fix

This on default, too.

Comment 8

[[e-mail] (:bhearsum)]

This landed in production today. Tomorrow morning I'll trigger the top-100 tests now that we know they won't eat the pool.