Closed Bug 639583 Opened 9 years ago Closed 9 years ago

Don't do a range-check/growStorageBy for the js::Vector::infallibleAppend methods

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

As Luke notes in bug 637905 comment 2, infallible appends need never allocate memory, so we can eliminate needless bounds-checks for that.
Attached patch PatchSplinter Review
Attachment #517842 - Flags: review?(luke)
Comment on attachment 517842 [details] [diff] [review]
Patch

Sorry for the delay, looks good.
Attachment #517842 - Flags: review?(luke) → review+
http://hg.mozilla.org/tracemonkey/rev/241c89f64f66
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/241c89f64f66
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.