Don't do a range-check/growStorageBy for the js::Vector::infallibleAppend methods

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
As Luke notes in bug 637905 comment 2, infallible appends need never allocate memory, so we can eliminate needless bounds-checks for that.
(Assignee)

Comment 1

7 years ago
Created attachment 517842 [details] [diff] [review]
Patch
Attachment #517842 - Flags: review?(luke)

Comment 2

7 years ago
Comment on attachment 517842 [details] [diff] [review]
Patch

Sorry for the delay, looks good.
Attachment #517842 - Flags: review?(luke) → review+
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/tracemonkey/rev/241c89f64f66
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/241c89f64f66
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.