Closed
Bug 639583
Opened 14 years ago
Closed 14 years ago
Don't do a range-check/growStorageBy for the js::Vector::infallibleAppend methods
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
4.72 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
As Luke notes in bug 637905 comment 2, infallible appends need never allocate memory, so we can eliminate needless bounds-checks for that.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #517842 -
Flags: review?(luke)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 517842 [details] [diff] [review] Patch Sorry for the delay, looks good.
Attachment #517842 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/241c89f64f66
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/241c89f64f66
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•