Closed Bug 639727 Opened 9 years ago Closed 9 years ago

don't try to shrink object slots during GC marking

Categories

(Core :: JavaScript Engine, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Instead of checking at every GC where we have to shrink slots, do so after having deleted a property from native objects. We give objects some wriggle room and only shrink once at least 25% of slots are unused. This code only hits for native objects (not arrays). I don't think is a particularly important path to shrink early, the shape associated with the property we delete uses many times more memory then the free slot itself.
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #517627 - Flags: review?(brendan)
Attachment #517627 - Flags: review?(brendan) → review?(bhackett1024)
Blocks: 639729
Attachment #517627 - Flags: review?(bhackett1024) → review+
http://hg.mozilla.org/tracemonkey/rev/b16be37906fe
Whiteboard: fixed-in-tracemonkey
Depends on: 643839
http://hg.mozilla.org/mozilla-central/rev/b16be37906fe
Status: NEW → RESOLVED
Closed: 9 years ago
OS: Mac OS X → Windows 7
Resolution: --- → FIXED
No longer depends on: 643839
Duplicate of this bug: 673205
You need to log in before you can comment on or make changes to this bug.