Closed
Bug 639727
Opened 13 years ago
Closed 13 years ago
don't try to shrink object slots during GC marking
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.84 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Instead of checking at every GC where we have to shrink slots, do so after having deleted a property from native objects. We give objects some wriggle room and only shrink once at least 25% of slots are unused. This code only hits for native objects (not arrays). I don't think is a particularly important path to shrink early, the shape associated with the property we delete uses many times more memory then the free slot itself.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Updated•13 years ago
|
Attachment #517627 -
Flags: review?(brendan)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #517627 -
Flags: review?(brendan) → review?(bhackett1024)
|
||
Updated•13 years ago
|
Attachment #517627 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/b16be37906fe
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b16be37906fe
Status: NEW → RESOLVED
Closed: 13 years ago
OS: Mac OS X → Windows 7
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•