639730 - Please check menuItem.tab instead of menuItem.hasAttribute("keepme")

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3705

3705       <handler event="popuphidden">
3706       <![CDATA[
3707         // clear out the menu popup and remove the listeners
3708         for (let i = this.childNodes.length - 1; i > 0; i--) {
3709           let menuItem = this.childNodes[i];
3710           if (!menuItem.hasAttribute("keepme")) {
3711             menuItem.removeEventListener("command", this, false);
3712             menuItem.tab.mCorrespondingMenuitem = null;
3713             this.removeChild(menuItem);
3714           }
3715         }
3716         var tabcontainer = gBrowser.tabContainer;
3717         tabcontainer.mTabstrip.removeEventListener("scroll", this, false);
3718         tabcontainer.removeEventListener("TabOpen", this, false);
3719         tabcontainer.removeEventListener("TabAttrModified", this, false);
3720         tabcontainer.removeEventListener("TabClose", this, false);
3721       ]]></handler>

Please remove the "keepme" attribute. It's unnecessary. Check menuItem.tab instead.

Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Verified fixed by check-in.