Last Comment Bug 639730 - Please check menuItem.tab instead of menuItem.hasAttribute("keepme")
: Please check menuItem.tab instead of menuItem.hasAttribute("keepme")
Status: VERIFIED FIXED
[fixed by bug 653655]
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Firefox 6
Assigned To: Frank Yan (:fryn)
:
Mentors:
Depends on: 653655
Blocks: 625320
  Show dependency treegraph
 
Reported: 2011-03-07 19:36 PST by ithinc
Modified: 2011-05-20 02:26 PDT (History)
3 users (show)
hskupin: in‑litmus-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description ithinc 2011-03-07 19:36:15 PST
User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3705

3705       <handler event="popuphidden">
3706       <![CDATA[
3707         // clear out the menu popup and remove the listeners
3708         for (let i = this.childNodes.length - 1; i > 0; i--) {
3709           let menuItem = this.childNodes[i];
3710           if (!menuItem.hasAttribute("keepme")) {
3711             menuItem.removeEventListener("command", this, false);
3712             menuItem.tab.mCorrespondingMenuitem = null;
3713             this.removeChild(menuItem);
3714           }
3715         }
3716         var tabcontainer = gBrowser.tabContainer;
3717         tabcontainer.mTabstrip.removeEventListener("scroll", this, false);
3718         tabcontainer.removeEventListener("TabOpen", this, false);
3719         tabcontainer.removeEventListener("TabAttrModified", this, false);
3720         tabcontainer.removeEventListener("TabClose", this, false);
3721       ]]></handler>

Please remove the "keepme" attribute. It's unnecessary. Check menuItem.tab instead.

Reproducible: Always
Comment 1 Henrik Skupin (:whimboo) 2011-05-20 02:26:15 PDT
Verified fixed by check-in.

Note You need to log in before you can comment on or make changes to this bug.