639771 - Port Bug 597315 [Frameset history does not work properly when restoring a tab] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch plus test

From parent bug:

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre

When browsing a site with framesets like the Java API documentation, if you
close the tab, then restore it and hit back the wrong frame will update.

The attached test case is a simplified copy of the API docs.

Reproducible: Always

This patch's test somehow affects to next test for bug 607016 on my Linux64 build, can't understand why, trying to figure it out.

Comment 1

[[e-mail]]

Comment on attachment 517693 [details] [diff] [review]
patch plus test

>+        browser.webNavigation.sessionHistory.getEntryAtIndex(activeIndex, true);
>+        browser.webNavigation.sessionHistory
>+               .QueryInterface(Components.interfaces.nsISHistory_2_0_BRANCH).reloadCurrentEntry();
Do you suppose it's worth rewriting this slightly to make it easier to update for after the 2.0 branch? Something like this:

var sessionHistory = browser.webNavigation.sessionHistory;
// delete this after 2.0
sessionHistory.QueryInterface(Components.interfaces.nsISHistory_2_0_BRANCH);

sessionHistory.getEntryAtIndex(activeIndex, true);
sessionHistory.reloadCurrentEntry();

Comment 2

[Misak Khachatryan]

Pushed: http://hg.mozilla.org/comm-central/rev/382b3365a2e9

I done as You suggested and also fixed test interference problem.