Closed
Bug 639771
Opened 13 years ago
Closed 13 years ago
Port Bug 597315 [Frameset history does not work properly when restoring a tab] to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file)
9.63 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
From parent bug: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b7pre) Gecko/20100916 Firefox/4.0b7pre Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b7pre) Gecko/20100916 Firefox/4.0b7pre When browsing a site with framesets like the Java API documentation, if you close the tab, then restore it and hit back the wrong frame will update. The attached test case is a simplified copy of the API docs. Reproducible: Always This patch's test somehow affects to next test for bug 607016 on my Linux64 build, can't understand why, trying to figure it out.
Attachment #517693 -
Flags: review?(neil)
Comment 1•13 years ago
|
||
Comment on attachment 517693 [details] [diff] [review] patch plus test >+ browser.webNavigation.sessionHistory.getEntryAtIndex(activeIndex, true); >+ browser.webNavigation.sessionHistory >+ .QueryInterface(Components.interfaces.nsISHistory_2_0_BRANCH).reloadCurrentEntry(); Do you suppose it's worth rewriting this slightly to make it easier to update for after the 2.0 branch? Something like this: var sessionHistory = browser.webNavigation.sessionHistory; // delete this after 2.0 sessionHistory.QueryInterface(Components.interfaces.nsISHistory_2_0_BRANCH); sessionHistory.getEntryAtIndex(activeIndex, true); sessionHistory.reloadCurrentEntry();
Attachment #517693 -
Flags: review?(neil) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Pushed: http://hg.mozilla.org/comm-central/rev/382b3365a2e9 I done as You suggested and also fixed test interference problem.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•