639818 - Wrong language is accepted from Accept-Language

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P3)

Description

[James Socol [:jsocol, :james]]

Consider the following Accept-Language header:

Accept-Language: en-gb, en;q=0.8, fr-fr;q=0.6, es;q=0.2

Which language is matched? Which one _should_ be matched?

Clearly, "en" should be matched and interpreted as "any English", sending the user to "en-US". However, in this case, "es" will be matched, the lowest priority.

This happens because right now we look for *complete* matches before looking for partial matches.

Comment 1

[James Socol [:jsocol, :james]]

https://github.com/jsocol/kitsune/commit/a1c8afeec

To test: use the Accept-Language header above and verify that you end up on 'en-US' instead of 'es'.

Comment 2

[Rebecca Billings [:rbillings]]

Verified