639843 - Port Bug 628270 [Undo close (hidden) tab causes panorama and session restore(?) to break unrecoverably]

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

This is hard to reproduce on SeaMonkey, but will be nice to pick up to keep in sync. From parent bug:

Prerequisites:
clean profile 

STR: 
1. Navigate some pages in a few tabs 
2. Go to panorama and close one of the tabs 
3. Return to normal mode 
4. Go back to panorama then reopen the previously closed tab (CMD + SHIFT + T) 

Behavior: 
The reopened tab is isolated from its native group and located in the upper
left corner of the panorama content area. 
It is mandatory to close and reopen panorama to reproduce this. If not, the tab
position will not hang, but you will shortly see that it appears on the left
upper corner for a second, then it's moved to its place in the group. 

This works on win7, and I could reproduce it only on mac os x 10.6 

Note: see screenshot

Comment 1

[[e-mail]]

Comment on attachment 517749 [details] [diff] [review]
patch

>-
>-      // make sure to restore the selected tab first (if any)
>-      if (aSelectTab-- && aTabs[aSelectTab]) {
>-        aTabs.unshift(aTabs.splice(aSelectTab, 1)[0]);
>-        aTabData.unshift(aTabData.splice(aSelectTab, 1)[0]);
>-        tabbrowser.selectedTab = aTabs[0];
>-      }
>+    }
>+
>+    // make sure to restore the selected tab first (if any)
>+    if (aSelectTab-- && aTabs[aSelectTab]) {
>+      aTabs.unshift(aTabs.splice(aSelectTab, 1)[0]);
>+      aTabData.unshift(aTabData.splice(aSelectTab, 1)[0]);
>+      tabbrowser.selectedTab = aTabs[0];
[I probably wouldn't have bothered with this change. If there's only one tab to restore, it must be the first tab!]

Comment 2

[Misak Khachatryan]

Pushed: http://hg.mozilla.org/comm-central/rev/f6a3e0ddd0f7

Comment 3

[Misak Khachatryan]

The righ one is: http://hg.mozilla.org/comm-central/rev/bcbd8015f6a2
Sorry :(