Last Comment Bug 639849 - Remove nsIDOM3Document
: Remove nsIDOM3Document
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla5
Assigned To: :Ms2ger
:
Mentors:
Depends on: 646184
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-08 08:24 PST by :Ms2ger
Modified: 2011-03-31 08:00 PDT (History)
4 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (32.18 KB, patch)
2011-03-08 08:24 PST, :Ms2ger
bzbarsky: review+
Details | Diff | Review
Patch for checkin (32.09 KB, patch)
2011-03-11 12:15 PST, :Ms2ger
no flags Details | Diff | Review
Patch for checkin (32.07 KB, patch)
2011-03-26 07:31 PDT, :Ms2ger
no flags Details | Diff | Review
rev more IIDs (2.71 KB, patch)
2011-03-29 19:14 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review

Description :Ms2ger 2011-03-08 08:24:43 PST
Created attachment 517750 [details] [diff] [review]
Patch v1
Comment 1 :Ms2ger 2011-03-08 08:34:26 PST
Looks like this needs bug 589894 to apply.
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-03-08 13:03:45 PST
Comment on attachment 517750 [details] [diff] [review]
Patch v1

>+++ b/dom/base/nsGlobalWindow.cpp
>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Just do:

  mDocument->GetDocumentURI(documentURI);

>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Likewise.

r=me with those nits.
Comment 3 :Ms2ger 2011-03-11 12:15:28 PST
Created attachment 518787 [details] [diff] [review]
Patch for checkin
Comment 4 :Ms2ger 2011-03-26 07:31:11 PDT
Created attachment 522107 [details] [diff] [review]
Patch for checkin
Comment 5 Dão Gottwald [:dao] 2011-03-26 14:01:43 PDT
http://hg.mozilla.org/projects/cedar/rev/f9e83c80242c
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2011-03-28 11:09:51 PDT
http://hg.mozilla.org/mozilla-central/rev/f9e83c80242c
Comment 7 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-03-29 19:11:51 PDT
Shouldn't this have rev'd IIDs on all interfaces that derive from nsIDOMDocument?  There are a bunch of crashes that seem to have showed up as a result of this, related to some Norton stuff and possibly other things -- and it's possible that it's not even really their fault.
Comment 8 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-03-29 19:14:35 PDT
Created attachment 522912 [details] [diff] [review]
rev more IIDs
Comment 9 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-03-29 19:18:08 PDT
Comment on attachment 522912 [details] [diff] [review]
rev more IIDs

r=me
Comment 10 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-03-29 20:56:08 PDT
http://hg.mozilla.org/mozilla-central/rev/4524bb785a79

Note You need to log in before you can comment on or make changes to this bug.