Remove nsIDOM3Document

RESOLVED FIXED in mozilla5

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 517750 [details] [diff] [review]
Patch v1
Attachment #517750 - Flags: review?(bzbarsky)
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Looks like this needs bug 589894 to apply.
Depends on: 589894
Whiteboard: [needs review]
Comment on attachment 517750 [details] [diff] [review]
Patch v1

>+++ b/dom/base/nsGlobalWindow.cpp
>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Just do:

  mDocument->GetDocumentURI(documentURI);

>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Likewise.

r=me with those nits.
Attachment #517750 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

6 years ago
No longer depends on: 589894
Whiteboard: [needs review] → [needs landing]
(Assignee)

Comment 3

6 years ago
Created attachment 518787 [details] [diff] [review]
Patch for checkin
Attachment #517750 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
Created attachment 522107 [details] [diff] [review]
Patch for checkin
Attachment #518787 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/projects/cedar/rev/f9e83c80242c
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
http://hg.mozilla.org/mozilla-central/rev/f9e83c80242c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2

Updated

6 years ago
Depends on: 646184
Shouldn't this have rev'd IIDs on all interfaces that derive from nsIDOMDocument?  There are a bunch of crashes that seem to have showed up as a result of this, related to some Norton stuff and possibly other things -- and it's possible that it's not even really their fault.
Created attachment 522912 [details] [diff] [review]
rev more IIDs
Attachment #522912 - Flags: review?(bzbarsky)
Comment on attachment 522912 [details] [diff] [review]
rev more IIDs

r=me
Attachment #522912 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/4524bb785a79
Looks so far like it did fix the crashes.  Crash queries with date ranges:

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:4.2a1pre&version=Firefox:4.0b13pre&query_search=signature&query_type=exact&query=&date=04%2F10%2F2011%2000%3A00%3A00&range_value=30&range_unit=days&hang_type=crash&process_type=browser&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsHTMLDocument%3A%3AGetElementsByName%28nsAString_internal%20const%26%2C%20nsIDOMNodeList**%29

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:4.2a1pre&version=Firefox:4.0b13pre&query_search=signature&query_type=exact&query=&date=04%2F10%2F2011%2000%3A00%3A00&range_value=30&range_unit=days&hang_type=crash&process_type=browser&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsDocument%3A%3AAdoptNode%28nsIDOMNode*%2C%20nsIDOMNode**%29
You need to log in before you can comment on or make changes to this bug.