Closed Bug 639851 Opened 9 years ago Closed 9 years ago

Master config should allow release only mode

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [releases][automation][buildmasters])

Attachments

(1 file, 1 obsolete file)

If you set ACTIVE_PROJECTS and ACTIVE_BRANCHES to [] builder masters fail with the following traceback. This is normal because buildObjects is not passed through mergeBuildObjects.

buildbot checkconfig
Traceback (most recent call last):
  File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/master.py", line 624, in loadConfig
    exec f in localDict
  File "/builds/buildbot/release-master/master/master.cfg", line 54, in <module>
    c['builders'].extend(buildObjects['builders'])
KeyError: 'builders'
Exception exceptions.AttributeError: "'NoneType' object has no attribute 'maxint'" in <bound method Popen.__del__ of <subprocess.Popen object at 0x400cef0c>> ignored
make: *** [check] Error 1
Attached patch Fix master configs (obsolete) — Splinter Review
This patch should fix the problem. Testing...
Depends on: 639838
Blocks: 639838
No longer depends on: 639838
Comment on attachment 517752 [details] [diff] [review]
Fix master configs

It passes test-master.sh and allows to create a release only master. I created one in staging. The builders page shows "release-*" builders only.
Attachment #517752 - Flags: review?(catlee)
Attachment #517752 - Flags: review?(catlee)
This one is clearer. Passes test-masters.sh.
Attachment #517752 - Attachment is obsolete: true
Attachment #518136 - Flags: review?(catlee)
Attachment #518136 - Flags: review?(catlee) → review+
How will this interact with slavealloc?
(In reply to comment #5)
> How will this interact with slavealloc?

These would fall under the release-only pool, right?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.