Closed Bug 639851 Opened 9 years ago Closed 9 years ago
Master config should allow release only mode
If you set ACTIVE_PROJECTS and ACTIVE_BRANCHES to  builder masters fail with the following traceback. This is normal because buildObjects is not passed through mergeBuildObjects. buildbot checkconfig Traceback (most recent call last): File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig ConfigLoader(configFileName=configFileName) File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/scripts/checkconfig.py", line 31, in __init__ self.loadConfig(configFile, check_synchronously_only=True) File "/builds/buildbot/release-master/sandbox/lib/python2.5/site-packages/buildbot-0.8.2_hg_cf597f8d9b94_default-py2.5.egg/buildbot/master.py", line 624, in loadConfig exec f in localDict File "/builds/buildbot/release-master/master/master.cfg", line 54, in <module> c['builders'].extend(buildObjects['builders']) KeyError: 'builders' Exception exceptions.AttributeError: "'NoneType' object has no attribute 'maxint'" in <bound method Popen.__del__ of <subprocess.Popen object at 0x400cef0c>> ignored make: *** [check] Error 1
This patch should fix the problem. Testing...
Comment on attachment 517752 [details] [diff] [review] Fix master configs It passes test-master.sh and allows to create a release only master. I created one in staging. The builders page shows "release-*" builders only.
This one is clearer. Passes test-masters.sh.
Comment on attachment 518136 [details] [diff] [review] Fix master configs http://hg.mozilla.org/build/buildbot-configs/rev/99d615003a87
Attachment #518136 - Flags: checked-in+
How will this interact with slavealloc?
(In reply to comment #5) > How will this interact with slavealloc? These would fall under the release-only pool, right?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.