639896 - The window controls look reversed in full-screen mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[(no longer active)]

Attachment: Screenshot

See the screenshot.  We should probably flip the images in RTL mode.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

I went ahead and landed an intl.css work-around for our RTL locales for Firefox 4.  This will need to be reverted when the patch lands post 2.0.

Tomer, Anas, please feel free to sign off this revision if you're happy with it.

http://hg.mozilla.org/l10n-central/fa/rev/6de9f1f1b879
http://hg.mozilla.org/l10n-central/he/rev/692d02ebdbda
http://hg.mozilla.org/l10n-central/ar/rev/3764a411a4da

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 517851 [details] [diff] [review]
Patch (v1)

This is wrong for Windows XP. You need to do this in browser-aero.css.

Comment 4

[(no longer active)]

Attachment: Patch (v2)

Addressed the review comment.

Comment 5

[Anas Husseini [:linostar]]

The bug appears in linux too. Won't we need to extend the patch to make it add the same lines to browser/themes/gnomestripe/browser/browser.css and browser/themes/pinestripe/browser/browser.css ?

By the way, why does intl.css need also to contain 'scaleX(-1)'. Won't two horizontal flips (one in browser.css and the other in intl.css) cancel each other?

Comment 6

[(no longer active)]

(In reply to comment #5)
> The bug appears in linux too. Won't we need to extend the patch to make it add
> the same lines to browser/themes/gnomestripe/browser/browser.css and
> browser/themes/pinestripe/browser/browser.css ?

Can you attach a screenshot of how the buttons look like on Linux?

> By the way, why does intl.css need also to contain 'scaleX(-1)'. Won't two
> horizontal flips (one in browser.css and the other in intl.css) cancel each
> other?

The intl.css hacks are only there for Firefox 4.  They need to be removed from l10n-central when this bug is fixed (I'll take care of doing that), but this bug won't make it for Firefox 4.

Comment 7

[(no longer active)]

Dao: ping?

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/00f27b89cd7b

Comment 9

[Vlad [QA]]

Verified fixed on Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110404 Firefox/4.2a1pre

Comment 10

[(no longer active)]

(In reply to comment #2)
> http://hg.mozilla.org/l10n-central/fa/rev/6de9f1f1b879
> http://hg.mozilla.org/l10n-central/he/rev/692d02ebdbda
> http://hg.mozilla.org/l10n-central/ar/rev/3764a411a4da

Backed out the intl.css hacks from all repositories:

http://hg.mozilla.org/l10n-central/fa/rev/c338bdff2272
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/c338bdff2272
http://hg.mozilla.org/l10n-central/he/rev/312de52547a2
http://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/312de52547a2
http://hg.mozilla.org/l10n-central/ar/rev/7e5c75e9caf1
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/7e5c75e9caf1