Closed
Bug 639915
Opened 14 years ago
Closed 14 years ago
Remove old & dead code
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: evilpie, Unassigned)
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file)
|
841 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Found some code, that i think is dead, in fun_getProperty. From my understanding the branch should never be taken, because fun_getProperty is never used as setter for this numbers.
|
Reporter | |
Updated•14 years ago
|
Attachment #517807 -
Flags: review?(jorendorff)
|
||
Updated•14 years ago
|
Attachment #517807 -
Attachment is patch: true
Attachment #517807 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 1•14 years ago
|
||
This looks correct to me. I wonder how long that code has been dead.
I put a JS_NOT_REACHED in there and I'm running the test suite right now, just to be absolutely sure.
|
||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> This looks correct to me. I wonder how long that code has been dead.
Over eleven years, Y2K. See bug 23346.
fun_getProperty is static so it's easy to audit. Good to kill this ancient dead code. Thanks, evilpie!
/be
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 517807 [details] [diff] [review]
Just kill it
This should have a JS_NOT_REACHED. r=me with that. I'll add it and push.
Attachment #517807 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 4•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•