Closed Bug 639915 Opened 9 years ago Closed 9 years ago
Remove old & dead code
Found some code, that i think is dead, in fun_getProperty. From my understanding the branch should never be taken, because fun_getProperty is never used as setter for this numbers.
Attachment #517807 - Flags: review?(jorendorff)
This looks correct to me. I wonder how long that code has been dead. I put a JS_NOT_REACHED in there and I'm running the test suite right now, just to be absolutely sure.
(In reply to comment #1) > This looks correct to me. I wonder how long that code has been dead. Over eleven years, Y2K. See bug 23346. fun_getProperty is static so it's easy to audit. Good to kill this ancient dead code. Thanks, evilpie! /be
Comment on attachment 517807 [details] [diff] [review] Just kill it This should have a JS_NOT_REACHED. r=me with that. I'll add it and push.
Attachment #517807 - Flags: review?(jorendorff) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.