640008 - Make it impossible to remove the only revision of an article

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[James Socol [:jsocol, :james]]

It's possible to remove the only revision of an article via the UI. We should hide the 'delete' UI and prevent it from working if there is only one revision.

STR:
1. Create a new article but don't approve it.
2. View history as someone with permission to delete revisions.

AR:
Able to delete only revision.

ER:
Impossible to delete only revision.


Another potential resolution is to make removing the only revision remove the entire article. Thoughts?

Comment 1

[Paul Craciunoiu [:paulc]]

(In reply to comment #0)
> Another potential resolution is to make removing the only revision remove the
> entire article. Thoughts?
How do you remove an article now, from the admin afaik? It might be good to offer non-admin UI for doing that.

Either way, deleting the last revision is a special case.

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> How do you remove an article now, from the admin afaik? It might be good to
> offer non-admin UI for doing that.

Only via the admin, which is why I'm nervous about doing that. I'd rather just make deleting the only revision impossible for the time being.

Comment 3

[Kadir Topal [:atopal]]

Well, ideally it would be possible to remove an article via the front-end. Then removing the last revision would show you a warning that the whole document is going to be removed. 

If that is not possible for now, please show a warning, stating that an admin has to delete the article.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/121570c69c3cfbda224b1e0ec4ec593588c9b536

Comment 5

[Rebecca Billings [:rbillings]]

Verified unable to delete only revision of the document- link exists which directs to message stating an admin must delete document