Closed Bug 640076 Opened 9 years ago Closed 9 years ago

TOK_XMLATTR tokens can span multiple lines

Categories

(Core :: JavaScript Engine, defect, critical)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: gkw, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase, Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files)

Attached file stack
Reflect.parse("<\"\n\"")

asserts js debug shell on TM changeset 80d8431f209e without -m nor -j at Assertion failure: IsTokenSane(tp),

May be related to bug 640075.

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   63253:3035bb782013
user:        Nicholas Nethercote
date:        Tue Mar 08 16:10:51 2011 -0800
summary:     Bug 638034 - Make scanning safer.  r=brendan.
See Also: → 640075
No time left today, I'll take a look tomorrow.  Thanks for the report, Gary!
Assignee: general → nnethercote
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Easy fix -- I forgot to include XMLATTR in the list of tokens that can span multiple lines.
Attachment #517978 - Flags: review?(brendan)
Comment on attachment 517978 [details] [diff] [review]
patch

Oh sure -- easy to forget about multiline attributes on XML elements.

/be
Attachment #517978 - Flags: review?(brendan) → review+
Summary: "Assertion failure: IsTokenSane(tp)," with Reflect.parse → TOK_XMLATTR tokens can span multiple lines
http://hg.mozilla.org/tracemonkey/rev/994a82955f31
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/994a82955f31
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.