Closed Bug 640167 Opened 13 years ago Closed 13 years ago

Port Bug 630723 [Deferred session restore doesn't work with browser.session_restore.resume_from_crash = false]

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
From parent bug:

After downloading the addon-sdk, creating a stub add-on with cfx init, and then
running it with cfx run, the profile used to use it is not recovering session
restore data.

more info:
Session restore works within the session, and the data appears to be correctly
saved to sessionstore.js. The .bak file created on startup is not being
updated.

Also interestingly to note is that it works if SS is set to "Show my windows
and tabs from last time"
Attachment #518048 - Flags: review?(neil)
Comment on attachment 518048 [details] [diff] [review]
fix

>-    // only read the session file if config allows possibility of restoring
>     var resumeFromCrash = prefBranch.getBoolPref("sessionstore.resume_from_crash");
>-    if ((!resumeFromCrash && !doResumeSession) || !sessionFile.exists())
[The var resumeFromCrash looks lonely now! I see it does get used later.]
Attachment #518048 - Flags: review?(neil) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/9164f554c96f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: