Closed Bug 640201 Opened 9 years ago Closed 9 years ago

mGeolocation should NOT be set before Init() is called

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Whiteboard: [land-fennec-4.1?])

Attachments

(1 file)

If Init() fails, then the next request for geolocation will return an uninit'ed object.  This doesn't happen in practice, but could.
Attached patch patch v.1Splinter Review
this doesn't happen in the wild with our geolocation provider, but could happen.  defensive at best.
Attachment #520666 - Flags: review?(jst)
nhirata, no.  see comment 1.
Attachment #520666 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/a8eb404a4286
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [land-fennec-4.1?]
No way to test this, as far as I understand it -- VERIFIED FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.